Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conditional export of all 'io' implementations. Addresses issue… #66

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

uldall
Copy link
Contributor

@uldall uldall commented Jul 1, 2024

Addresses #65

Description

Only export Linux, MacOS and Windows implementations when not on web.

@uldall
Copy link
Contributor Author

uldall commented Jul 1, 2024

I am not an expert on how the export keyword works, so hopefully someone else can determine if this approach is correct.

@diegotori
Copy link
Collaborator

@uldall Thanks for your contribution.

This actually works fine because you're properly bucketing dart:io usage away from web.

Once the automation passes, then I'll approve.

Copy link
Collaborator

@diegotori diegotori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@diegotori
Copy link
Collaborator

@uldall since it's the fourth of July holiday weekend here in the States, the earliest that this will get deployed is on Monday.

Thanks for your contribution.

@uldall
Copy link
Contributor Author

uldall commented Jul 12, 2024

@uldall since it's the fourth of July holiday weekend here in the States, the earliest that this will get deployed is on Monday.

Thanks for your contribution.

No problem, thank you for taking your time to look into this :)

@uldall
Copy link
Contributor Author

uldall commented Jul 28, 2024

Hi @diegotori, would it possible to get this merged and released? Then I wouldn't have to keep a separate build which would be quite nice :) Thank you in advance!

@diegotori
Copy link
Collaborator

@uldall sure. Lemme just merge it first. In the meantime, override the dependency so that it gets it from git main

@diegotori diegotori merged commit a4f7e5f into fluttercommunity:main Jul 28, 2024
14 checks passed
@diegotori
Copy link
Collaborator

@uldall released as part of version 1.2.6. Once again, thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants