Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/fms): Fix refueling msg on A380X #9698

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

iurynogueira
Copy link

Fixes #9696

Summary of Changes

Change refueling msg on center console

References

Reference on issue by @tshomas

Additional context

Discord username (same from GitHub): iurynogueira

Testing instructions

A380X only:

  1. Turn on the aircraft
  2. Start refueling the plane
  3. Look at display

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@iurynogueira iurynogueira changed the title (fix): Fix refueling msg on A380X fix(a380x/fms): Fix refueling msg on A380X Jan 1, 2025
@flogross89 flogross89 added this to the v0.13.0 milestone Jan 2, 2025
@flogross89 flogross89 added FWS Flight Warning Computer (ata-31) QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Jan 2, 2025
Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Since this is a small change, we can live without full QA. Could you please add a screenshot showing the correct ECAM message in MSFS to this PR? Then we can merge.

@flogross89 flogross89 added QA Not Required and removed QA A380 Only QA only for A380 required labels Jan 2, 2025
Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had another look at the references, sorry for the confusion

@@ -32,7 +32,7 @@ export class FwsMemos {
flightPhaseInhib: [],
simVarIsActive: this.fws.usrStartRefueling,
whichCodeToReturn: () => [0],
codesToReturn: ['000005001'],
codesToReturn: ['280000009', '280000010'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
codesToReturn: ['280000009', '280000010'],
codesToReturn: ['280000009', this.fws.oneEngineRunning.get() ? '280000011' : '280000010'],

REFUEL PNL DOOR OPEN exists as both amber and green variant (depending on whether one engine is started or not). Thus, also please change the memo entry in EcamMessages/index.tsx to '280000011': '\x1b<4mREFUEL PNL DOOR OPEN',

Co-authored-by: floridude <63071941+flogross89@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft FWS Flight Warning Computer (ata-31) QA Not Required
Projects
Status: 🔴 Code Review: In progress
Development

Successfully merging this pull request may close these issues.

Center Console says "REFUELG" instead of "REFUELING"
2 participants