fix(fms): fix prediction crash due to invalid thrust limit prediction #9719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
#9358 changed the way thrust limits were computed for predictions because the computation had to be separated between planes. In the separation, I introduced a bug that confused N1 for Corrected N1. This caused predictions to be nonsensical when the thrust limit was insufficient to keep climbing.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Make different flight plans at different weights, check that the T/C position makes sense and that it roughly coincides with the SimBrief prediction. Some deviation is expected due to different wind/temperature models.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.