Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fms): fix prediction crash due to invalid thrust limit prediction #9719

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BlueberryKing
Copy link
Member

Fixes #[issue_no]

Summary of Changes

#9358 changed the way thrust limits were computed for predictions because the computation had to be separated between planes. In the separation, I introduced a bug that confused N1 for Corrected N1. This caused predictions to be nonsensical when the thrust limit was insufficient to keep climbing.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Make different flight plans at different weights, check that the T/C position makes sense and that it roughly coincides with the SimBrief prediction. Some deviation is expected due to different wind/temperature models.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@BlueberryKing BlueberryKing changed the title fix(fms): fix prediction crash to due invalid thrust limit prediction fix(fms): fix prediction crash due to invalid thrust limit prediction Jan 5, 2025
@Saschl
Copy link
Contributor

Saschl commented Jan 9, 2025

Quality Assurance TesterReport

Discord Username : saschl
Object of testing : #9719
Aircraft : A380X
Tier of Testing : 2
Date : 08/01/2025

Testing Process:

  1. Flight from KJFK to KMCO
  2. Observed TOC and TOD behaviour and placements seemed reasonable. No crashes could be observed
  3. Loaded up another flightplan (EDDM-EDDF) and verified TOC placement being reasonable

Testing Results:
Passed

Media:

Screenshot 2025-01-08 190007
Screenshot 2025-01-08 185852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🟣 QA Review: Ready to Test
Development

Successfully merging this pull request may close these issues.

2 participants