Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kms additions #731

Merged
merged 23 commits into from
Dec 17, 2024
Merged

kms additions #731

merged 23 commits into from
Dec 17, 2024

Conversation

geemus
Copy link
Member

@geemus geemus commented Dec 9, 2024

  • add kms test lint fixes
  • remove unused default key policy constant from KMS create key request
  • minor cleanup and add first pass at schedule_key_deletion method and mock

geemus added 21 commits December 16, 2024 15:54
@geemus
add kms test lint fixes
3f89d37
@geemus
remove unused default key policy constant from KMS create key request
db1faeb
@geemus
minor cleanup and add first pass at schedule_key_deletion method and …
010b621 
…mock
@geemus
fix for schedule_key_deletion test
c6c4a25
@geemus
[kms] convert create_key to options hash instead of positional arguments
13094ba
@geemus
fix mock data after options hash change
48e1d83
@geemus
add KeySpec to create_key mock and expected format in tests
4b91783
@geemus
first pass at get_public_key requests and mocks
351512f
@geemus
fix params for create_key in tests so that public_key/signing mocks w…
6e78c02 
…ill match
@geemus
size for rsa key should be cast to integer
d8cf0a2
@geemus
add mocks for ECC pkeys
feeb15b
@geemus
first pass at kms sign request and mocks
68e717e
@geemus
simplify by using sign instead of sign_raw
a6e2dab
@geemus
switch to sign_pss, hopefully compatible with 3.0
2812138
@geemus
fix ec curve mapping
37f60b6
@geemus
kms: mocks - cleanup signopts, support both raw and digest signing
3e67ab0
@geemus
starting to flesh out mock tests around signing/verification
13ab68e
@geemus
further fleshing out/refining tests
61d340a
@geemus
add mock table tests for signing
fe614bc
@geemus
get_public_key KeyId is actually ARN, also delete after sign table te…
828d761 
…st, just in case
@geemus
add missing keyspec to describe_key parser
1dfc9e6
@geemus geemus marked this pull request as ready for review December 16, 2024 17:12
@geemus geemus merged commit 43a6fd5 into master Dec 17, 2024
7 checks passed
@geemus geemus deleted the kms-additions branch December 17, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@geemus