Skip to content

Commit

Permalink
STCOR-913 Don't override initial discovery and okapi data in test moc…
Browse files Browse the repository at this point in the history
…ks (#1564)

Updating `stripes-core` in SSC causes 30+ tests to fail.
folio-org/stripes-smart-components#1538
This PR addresses some issues which cause these failures.

Overwriting of initial okapi and discovery data in `setupApplication`
helper. Some tests require custom okapi data, but `setupApplication` in
some cases can overwrite that data which makes those tests fail.

Still investigating a few failing tests so maybe there's something
else that needs to be fixed.
  • Loading branch information
BogdanDenis authored Nov 21, 2024
1 parent 943d67a commit 1c73afd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* Send the stored central tenant name in the header on logout. Refs STCOR-900.
* Provide `<IfAnyPermission>` and `stripes.hasAnyPermission()`. Refs STCOR-910.
* Use the `users-keycloak/_self` endpoint conditionally when the `users-keycloak` interface is present; otherwise, use `bl-users/_self` within `useUserTenantPermissions`. Refs STCOR-905.

* Don't override initial discovery and okapi data in test mocks. Refs STCOR-913.

## [10.2.0](https://github.com/folio-org/stripes-core/tree/v10.2.0) (2024-10-11)
[Full Changelog](https://github.com/folio-org/stripes-core/compare/v10.1.1...v10.2.0)
Expand Down
3 changes: 3 additions & 0 deletions test/bigtest/helpers/setup-application.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export default function setupApplication({
// when auth is disabled, add a fake user to the store
if (disableAuth) {
initialState.okapi = {
...initialState.okapi,
currentUser: assign({
id: 'test',
username: 'testuser',
Expand All @@ -55,10 +56,12 @@ export default function setupApplication({
isAuthenticated: true,
};
initialState.discovery = {
...initialState.discovery,
isFinished: true,
};
} else {
initialState.okapi = {
...initialState.okapi,
ssoEnabled: true,
};
}
Expand Down

0 comments on commit 1c73afd

Please sign in to comment.