Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-860 correctly populate stripes.user.user on reload #1493

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

zburke
Copy link
Member

@zburke zburke commented Jun 17, 2024

When resuming an existing session, populate stripes.user.user exactly the same way as when creating a new session. Principally, this means leveraging the return value from spreadUserWithPerms over user, instead of using the raw user value from the response, which spreads the user.personal attributes.

Refs STCOR-860

When resuming an existing session, populate `stripes.user.user` exactly
the same way as when creating a new session. Principally, this means
leveraging the return value from `spreadUserWithPerms` over `user`,
instead of using the raw `user` value from the response, which spreads
the `user.personal` attributes.

Refs STCOR-860
@zburke zburke requested review from JohnC-80 and a team June 17, 2024 14:50
Copy link

github-actions bot commented Jun 17, 2024

Jest Unit Test Results

  1 files  ±0   38 suites  ±0   47s ⏱️ ±0s
283 tests ±0  283 ✅ ±0  0 💤 ±0  0 ❌ ±0 
284 runs  ±0  284 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 511879f. ± Comparison against base commit ac49090.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 17, 2024

Bigtest Unit Test Results

193 tests  ±0   188 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 511879f. ± Comparison against base commit ac49090.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Dmitriy-Litvinenko Dmitriy-Litvinenko requested a review from a team June 18, 2024 07:39
@zburke zburke merged commit 37ec41f into master Jun 18, 2024
26 checks passed
@zburke zburke deleted the STCOR-860 branch June 18, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants