[fio extras] storage: allow target to be marked as bad #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-sul
reviewed
Dec 20, 2024
mike-sul
reviewed
Dec 20, 2024
This feature is required to allow a rollback operation to be forced on a target whose installation was finished. Signed-off-by: Andre Detsch <andre.detsch@foundries.io>
An additional option is included to allow filtering out current target from installed versions list. This is required to properly select the a rollback target after installation was finalized, and there was not ostree update, only apps. Signed-off-by: Andre Detsch <andre.detsch@foundries.io>
detsch
force-pushed
the
detsch-user-rollback
branch
from
d29fafd to
7f8a23b
Compare
mike-sul
reviewed
Jan 3, 2025
| @@ -1118,6 +1118,17 @@ void SQLStorage::saveInstalledVersion(const std::string& ecu_serial, const Uptan | |||
| LOG_ERROR << "Failed to save installed versions: " << db.errmsg(); | |||
| return; | |||
| } | |||
| } else if (update_mode == InstalledVersionUpdateMode::kBadTarget) { | |||
There was a problem hiding this comment.
At first glance, it looks like this if is better suited in the if else below before if (!!old_id).
if (update_mode == InstalledVersionUpdateMode::kBadTarget) {
...
} else if (!!old_id) {
...
What do you think?
mike-sul
approved these changes
Jan 3, 2025
When the virtual environment has a reboot pending, prioritize the use of `is_current` from database, instead of forcing the use of a target that matches the latest ostree hash. This approximates the behavior to the one observed in actual devices (booted mode) when there is a reboot pending after an install operation. Signed-off-by: Andre Detsch <andre.detsch@foundries.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is required to allow a rollback operation to be forced on a target whose installation was finished.