[pull] develop from frappe:develop #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Also no need to check channel names?
One can set it in conf and it won't work as expected because pubsub format is different
Picking 1024 keys assuming 4kb avg size. In practice most things are smaller so 1024 should be good enough! This will likely only affect multitenant deploy with many sites.
We can be more aggressive later, this is a good starting parting.
Imagine: | client 1 | client 2 | | --- | --- | | rd(x) | | | | wr(x) | | inv(x) | | | rd(x) | | <- This will end up using request specific cache!
This is required if we do NOLOOP
Drops redis connection per worker from 3 to 2! Nothing wrong with doing this.
Similar to recent _SITE_CACHE change, it's not required. Properly cleared keys will get invalidated anyway.
This get+conditional set is also slightly prone to data races, but doesn't seem to be harmful as of now. Rationale: - To enable recorder one must first send a request, so this should be set long before. - While enabling we can accidentally clear cache for another worker by invalidating it, but that is kind of acceptable behaviour. We ONLY set it to False when `None` is received from Redis. Local invalidations remove it completely.
This reverts commit 55a55e7.
- This should not be in init.py - set_single_value is not a good alternate for properly cleaning up cache.
Fix for the documented example given here: https://redis.io/docs/latest/develop/reference/client-side-caching/#avoiding-race-conditions
These can be used for logging or debugging the behaviour of the cache.
feat: display two lines in image view
These are just simple strings, and default of 128 isn't enough. Just 4-5 list views will fill that up.
feat(cache): server-assisted client-side caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )