[pull] develop from frappe:develop #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
fix: Make client cache work without redis too
perf: Ignoring linked doctypes on cancel
* perf: Reduce penalty for lack of redis connection If redis isn't running than this client cache is slower than default implementation because of the extra locking overhead. * test: update perf redis counts * perf: cache table columns in client-cache * fix: race condition on cache-client_cache init Rare but apparant in synthetic benchmarks. Cache is set but client cache is still being initialized then request will fail. * perf: Don't run notifications when loading document WHAT? * fix: use cached doc to repopulate * perf: reduce get_meta calls
Dynamic route evaluation is insanely slow and done on each request. I'll likely remove that over time but in meantime, this resolution should be much higher.
* fix: Consume sid from arguments * perf: do not validate user on resume Errr, why would we ever need to validate if user with active session is "disabled"? When active user is disabled, their sessions are wiped from cache and DB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )