Merge pull request #1905 from frappe/develop

dev to main
frappe · Aug 7, 2024 · fa1519f · fa1519f
2 parents ebc202e + a6652a2
commit fa1519f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/desk/src/pages/TicketNew.vue b/desk/src/pages/TicketNew.vue
@@ -146,7 +146,14 @@ const ticket = createResource({
     }
   },
   onSuccess: (data) => {
-    if (isCustomerPortal) return;
+    router.push({
+      name: route.meta.onSuccessRoute as string,
+      params: {
+        ticketId: data.name,
+      },
+    });
+    if (!isCustomerPortal) return;
+    // only capture telemetry for customer portal
     capture("new_ticket_submitted", {
       data: {
         user: userID,
@@ -156,12 +163,6 @@ const ticket = createResource({
         customFields: templateFields,
       },
     });
-    router.push({
-      name: route.meta.onSuccessRoute as string,
-      params: {
-        ticketId: data.name,
-      },
-    });
   },
   onError: useError(),
 });

diff --git a/desk/src/telemetry.ts b/desk/src/telemetry.ts
@@ -73,7 +73,10 @@ interface CaptureOptions {
   };
 }
 
-export function capture(event: string, options: CaptureOptions = { data: {} }) {
+export function capture(
+  event: string,
+  options: CaptureOptions = { data: { user: "" } }
+) {
   if (!telemetry.value.enabled) return;
   window.posthog.capture(`${APP}_${event}`, options);
 }