Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue where assignment form is popped up on add quiz button in Lesson Edit form #1235

Merged

Conversation

FahidLatheef
Copy link
Contributor

@FahidLatheef FahidLatheef commented Jan 7, 2025

  • Assignment Form is popped up when New Quiz is tried to be added in Lesson Edit form
  • Issue is arising due to missing prop passed in AssessmentPlugin Component
Screen.Recording.2025-01-07.at.8.35.04.PM.mov

Copy link

cypress bot commented Jan 7, 2025

lms    Run #958

Run Properties:  status check passed Passed #958  •  git commit 1c569bb43c ℹ️: Merge f6577acbff53a9c7423d4f531ba04196a6e897dd into 9dcfc347d91432918156b4f164c7...
Project lms
Branch Review fix/assignment-popup-on-edit-quiz
Run status status check passed Passed #958
Run duration 00m 34s
Commit git commit 1c569bb43c ℹ️: Merge f6577acbff53a9c7423d4f531ba04196a6e897dd into 9dcfc347d91432918156b4f164c7...
Committer Fahid Latheef A
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@FahidLatheef FahidLatheef changed the title fix: fix issue where assignment form is popped up on edit quiz button in Lesson Edit form fix: fix issue where assignment form is popped up on add quiz button in Lesson Edit form Jan 7, 2025
@pateljannat pateljannat merged commit eb6b725 into frappe:develop Jan 8, 2025
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants