Skip to content

Commit

Permalink
Try disabling ASAN on GitHub
Browse files Browse the repository at this point in the history
It passes asan locally, so guessing missing runtime library
  • Loading branch information
fredemmott committed Jan 3, 2024
1 parent 3d063ef commit 4a7171d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ set(CMAKE_CXX_EXTENSIONS OFF)

# - Use ASAN for debug builds
# - statically link to statically link the ASAN runtime
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" AND NOT $ENV{GITHUB_RUN_NUMBER})

This comment has been minimized.

Copy link
@fredemmott

fredemmott Jan 3, 2024

Author Owner

Yeah, this fixes it.

actions/runner-images#8891

add_compile_options(
"$<$<CONFIG:Debug>:/fsanitize=address>"
"$<$<CONFIG:Debug>:/MTd>"
Expand Down

0 comments on commit 4a7171d

Please sign in to comment.