Skip to content
Style Checker

x86 PICs as devices #2185

Sign in to view logs

x86 PICs as devices

x86 PICs as devices #2185

Triggered via pull request December 23, 2024 22:28
@ehemehem
synchronize #1457
ehem:x86picdev
Status Failure
Total duration 1m 5s
Artifacts –

style.yml

on: pull_request
Style Checker
56s
Style Checker
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 11 warnings
Style Checker: sys/x86/include/intr_machdep.h#L104
space required before the open parenthesis '('
Style Checker: sys/x86/include/intr_machdep.h#L119
space required before the open parenthesis '('
Style Checker: sys/x86/include/intr_machdep.h#L124
space required before the open parenthesis '('
Style Checker: sys/x86/include/intr_machdep.h#L133
space required before the open parenthesis '('
Style Checker: sys/arm/mv/gpio.c#L80
if this code is redundant consider removing it
Style Checker: sys/arm/mv/gpio.c#L108
if this code is redundant consider removing it
Style Checker: sys/arm/mv/gpio.c#L114
if this code is redundant consider removing it
Style Checker: sys/arm/mv/gpio.c#L131
if this code is redundant consider removing it
Style Checker: sys/arm/mv/gpio.c#L134
if this code is redundant consider removing it
Style Checker: sys/arm/mv/gpio.c#L142
if this code is redundant consider removing it
Style Checker
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Style Checker: sys/x86/xen/xen_arch_intr.c#L341
Missing Signed-off-by: line
Style Checker: sys/x86/isa/atpic.c#L385
Missing Signed-off-by: line
Style Checker: sys/x86/xen/xen_arch_intr.c#L251
Missing Signed-off-by: line
Style Checker: sys/x86/x86/io_apic.c#L908
Missing Signed-off-by: line
Style Checker: sys/x86/x86/intr_machdep.c#L151
braces {} are encouraged even for single statement blocks
Style Checker: sys/x86/xen/xen_arch_intr.c#L266
Missing Signed-off-by: line
Style Checker: sys/x86/xen/xen_arch_intr.c#L194
Missing Signed-off-by: line
Style Checker: sys/x86/isa/clock.c#L576
Missing Signed-off-by: line
Style Checker: sys/x86/isa/atpic.c#L294
Missing Signed-off-by: line
Style Checker: sys/x86/isa/atpic.c#L158
Missing Signed-off-by: line