Fix court string matching with whitespace

[mattdahl]

As discussed in #135 (comment), there is presently a bug where court strings without whitespace are not properly matched. 3b2fe09 implements a failing test for this bug. 94b1e2f implements a simple fix.

This PR is also related to the changes proposed in #129, but I think that that proposal has been made obsolete with the removal of all the duplicate citation strings by @flooie (#135 (comment)). In any case, this PR addresses a different problem re whitespace.

Note that this PR is based off of #143 (needed to update black to make GitHub Actions happy), so that should be merged first.

[mlissner]

LGTM.

My understanding is that in this comment #135 (comment), @flooie eliminated duplicate abbreviations from courts DB, so now it's safe to do things like this.

@flooie, wil you give this a quick review too? The only changes you need to look at are in resolve.py, the rest is updating Black.

Assuming this is good, we need to return to:

• Court name issues #129 (might be obsolete)
• Court name errors #128 (might be fixed)
• Getting full citation span #135 (don't we already support this, regardless of the code here?)

[mlissner]

@flooie looks like this one never got your approval. Mind taking a look, please?

[mattdahl]

Want me to rebase this?

[mlissner]

That'd be great, thanks @mattdahl

[mattdahl]

Thanks for merging that other PR, @flooie. I just rebased this one as well.

N.B., I previously suggested that #129 had been made obsolete by intervening changes. This is false. More notes over there.

[flooie]

Thanks. I'll take a look soon.

[quevon24]

I added a few lines because if you test it with "Commonwealth v. Muniz, 164 A.3d 1189 (Pa. 2017)" as mentioned in the issue, it now returns "njcirctpassaic" instead of "pa", this happens because the first court in the list returned by courts-db that starts with "Pa" is "Passaic Cty. Cir. Ct., N.J."

I added a check to look for an exact match before try the startswith approach, for this specific case this approach works.

[mattdahl]

Thanks, I agree that looking for an exact match first is good (cf. #129 (comment)).

But can we refactor this so we only iterate over courts once?

Something like:

def get_court_by_paren(paren_string: str) -> Optional[str]:
    """Takes the citation string, usually something like "2d Cir", and maps
    that back to the court code.

    Does not work on SCOTUS, since that court lacks parentheticals, and
    needs to be handled after disambiguation has been completed.
    """
    court_str = strip_punct(paren_string)
    court_str = court_str.replace(" ", "")

    court_code = None
    if court_str:
        for court in courts:
            s = strip_punct(court["citation_string"]).replace(" ", "")
    
            # Check for an exact match first
            if s == court_str:
                return court["id"]
    
            # If no exact match, try to record a startswith match for possible eventual return
            if s.startswith(court_str):
                court_code = court["id"]
    
        return court_code

[quevon24]

Thanks, I agree that looking for an exact match first is good (cf. #129 (comment)).

But can we refactor this so we only iterate over courts once?

Something like:

def get_court_by_paren(paren_string: str) -> Optional[str]:
    """Takes the citation string, usually something like "2d Cir", and maps
    that back to the court code.

    Does not work on SCOTUS, since that court lacks parentheticals, and
    needs to be handled after disambiguation has been completed.
    """
    court_str = strip_punct(paren_string)
    court_str = court_str.replace(" ", "")

    court_code = None
    if court_str:
        for court in courts:
            s = strip_punct(court["citation_string"]).replace(" ", "")
    
            # Check for an exact match first
            if s == court_str:
                return court["id"]
    
            # If no exact match, try to record a startswith match for possible eventual return
            if s.startswith(court_str):
                court_code = court["id"]
    
        return court_code

great, thanks, it looks more readable, I'll push this change

[quevon24]

There is a new PR for all checks to pass correctly: #188