Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump golangci-lint from v1.45.2 → v1.55.2 #133

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

irvinlim
Copy link
Member

Fixes broken lint CI step: https://github.com/furiko-io/furiko/actions/runs/7629655551/job/20783547238

  • Bumps golangci-lint from v1.45.2 → v1.55.2
  • Support versioned golangci-lint in ./bin in case the version is updated
  • Remove deprecated linters
  • Fix lint errors with stricter linter checks, remove a bunch of unused code
  • Add several lint exclusions in case of false positives

@irvinlim irvinlim self-assigned this Jan 23, 2024
@irvinlim irvinlim force-pushed the irvinlim/chore/fix-lint branch 2 times, most recently from d59e4c1 to c08a313 Compare February 17, 2024 17:14
@irvinlim
Copy link
Member Author

Tests will be fixed in the next PR, because we need more debugging to find out why it fails only in CI.

@irvinlim irvinlim merged commit 4a40039 into main Feb 17, 2024
8 of 10 checks passed
@irvinlim irvinlim deleted the irvinlim/chore/fix-lint branch February 17, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant