Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.1 #25

Closed
wants to merge 9 commits into from
Closed

Version 1.0.1 #25

wants to merge 9 commits into from

Conversation

ssestak
Copy link
Contributor

@ssestak ssestak commented Aug 1, 2024

  • Template Updates
    • Removed SwiftLint warnings
    • Omitted application prefix in naming
    • Dropped class prefix in mock view model events
  • Added commentary explaining anti-pattern of adding view modifiers in coordinator root view
  • Alerts no longer managed by coordinators; their presentation is now individual view's responsibility
  • Scene Delegate
    • Introduced view modifier in helpers
  • Destination IDs
    • Integrated @EnumIdentifiersGenerator macro for auto-generating code for Hashable and Identifiable protocol conformance
    • The macro produces nested enum for ID generation for enum cases
  • Introduced FlowProvider in helpers
  • For coordinators, integrated ModalCoverModel<Destination> to avoid UI confusion regarding sheet and full screen cover presentation order

Prerequisites for Merging:

  • New projects must specify a key-value pair for LaunchScreen in Info.plist to ensure proper display
  • Macro
    • Requires importing EnumIdentifiersGenerator currently, but ideally, it should be part of FuturedArchitecture
    • It doesn't account for situation when Destination ID needs to be computed using an associated value
      • UPDATE: DONE

Macro Expansion Example:
image

@@ -0,0 +1,22 @@
//
// File.swift
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// File.swift
// ModalCoverModel.swift

import Foundation

@attached(member, names: arbitrary)
public macro EnumIdentifiersGenerator() = #externalMacro(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnumIdentifiersGenerator zvážil bych jiné jméno :) 🤔

@ssestak ssestak marked this pull request as ready for review August 3, 2024 17:07
@ssestak ssestak closed this Aug 7, 2024
@ssestak ssestak deleted the feature/v1.0.1 branch August 7, 2024 12:06
@ssestak
Copy link
Contributor Author

ssestak commented Aug 7, 2024

Closed due to renaming the branch. New PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants