Housekeep: Remove legacy files and polish the Coordinator API #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samoilyk
previously approved these changes
Aug 23, 2024
ssestak
reviewed
Aug 23, 2024
samoilyk
approved these changes
Aug 23, 2024
ssestak
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File removal rational
AnyShapeandFuturedLibraryContentProvider- Manual box is no longer needed due to existential anyPublisher+ResourcePublisher+ResultResource- Architecture no longer requires those typesURL+ExpressibleByStringLiteral- Such code should not be shipped with architecture library, also the general idea is outdated, use Macro for buildtime verificationsOther changes:
ModalCoverModel<T>.Stylewas moved to global non-generic scope (ModalCoverModelStyle). This enum is primitive, does not benefit from the generic context and may cause some issues in the future.