Implement symbol downloading without symchk.exe #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrChat
force-pushed
the
fetch_async
branch
2 times, most recently
from
ab91ba1 to
f6804fa
Compare
|
This looks good. I won't want to merge it in yet until it supported compressed PDBs as that seems to be the primary format at least from MSDL symbol store (unless something has changed). I've done something like this before, and historically I had case sensitivity issues. I can't remember if it was on the download side, the storage side, or the symbol matching side. But something to be aware of. Looks goo otherwise. |
|
👍 - It doesn't appear that Microsoft offers compressed PDBs (oddly enough). Do you have a good test case for compressed PDBs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #3.
Note that we still don't handle more advanced forms of
_NT_SYMBOL_PATH- only the most basic.This set of changes also does not handle compressed symbols, or alternate symbol server layouts (indicated by the presence of index2.txt).
This does however break the dependency on symchk.exe, allowing this tool to be used on Linux machines the same as Windows.
In addition, a design of using a thread pool is certainly more efficient than spawning multiple copies of symchk.exe.
More to potentially come as features are needed.