add hdf5 requirement for macOS #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I needed to install it, but I'm not sure if there is a better way to avoid it. This PR is just a suggestion. |
|
I think HDF5 is an edge case and most users will probably stick to the other formats that are supported, if they even utilize the export/import. Requiring HDF5 by default may be less helpful as one might not want to install the HDF5 lib. In addition to the text you've added, I'd suggest providing it as an extra dependency if wished and to import it when needed. Users then may install it like this: pip install easydataverse["hdf5"]What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.