Production deployment 6th July 2022 #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Article::for_site finds by tag and neighbourhood and documentation/tests of Article.with_site scope
Bumps [rails-html-sanitizer](https://github.com/rails/rails-html-sanitizer) from 1.4.2 to 1.4.3. - [Release notes](https://github.com/rails/rails-html-sanitizer/releases) - [Changelog](https://github.com/rails/rails-html-sanitizer/blob/master/CHANGELOG.md) - [Commits](rails/rails-html-sanitizer@v1.4.2...v1.4.3) --- updated-dependencies: - dependency-name: rails-html-sanitizer dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ivan Kocienski <ivan.kocienski@gmail.com>
* Don't show root users the no-content warning When logged in as a root user (who has no content) and on the home dashboard page then don't show the no content nag box Also: users who are editors have content even if they have no tags, neighbourhoods or partners. Like root users.
kimadactyl
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1363 partner opening times data can have invalid JSON
Some of the data in partner
opening_timesfields was badly formed.With badly formed JSON data:
With valid JSON data:
#1364 No rights message on admin dashboard and profile page
When citizens log in and have no tags, neighbourhoods or partners they should see a message on the dashboard and their profile page. This is not the case if the user has the root role.
Dashboard home screen:
Profile page (bottom):
#1369 Articles on sites news page can be found by location (address) and tag
When an article has the
footag applied and a site has afootag in its selected tags field, then that article should appear on the site, regardless of location. This is in addition to the previous behaviour of finding articles published from partners that have neighbourhoods in the Site's neighbourhoods.Articles found by both tag and address
#1368 Blank editors don't see 'no content' warning (from #1364)
As an extension of 1364: users with editor roles do not see the blank content warning.
As a blank citizen:
As a blank root:
As a blank editor: