import our view_component stylesheets explicitly #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moving off mountain_view
ivan-kocienski-gfsc
approved these changes
Feb 19, 2024
aaaaargZombies
deleted the
2252-detangle-view_componentd-mountain_view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2252
description
I took a look at #1319 and think removing
mountain_viewmight be a required step to getting everything building through the standard asset pipeline.That raised the issue that we were using
mountain_viewto import ourview_componentstyles (and why we were surprised we couldn't colocate styles in the GI project)This work is a first step in weaning us off
mountain_viewand putting a structure in place for adding future components... but It was a Friday special where I wrote the AC and PR on my own so perhaps Monday eyes will uncover something important I missed.