Add maxwidth setting for album art

[returntoreality]

This allows setting album_art_maxwidth (same setting name as in the convert plugin) to restrict the maximum size of the embedded album art.

[geigerzaehler]

Thanks for your contribution, @returntoreality! Would you mind adding documentation and tests for this feature?

You can document the feature by adding albumart_maxwidth to the configuration section of the Readme. Please reference the documentation of the convert plugin.

A test can be added to the test_embed_art test case. I’d suggest you assert that the original album art is larger than the embedded one and the embedded art’s width matches the max width. (You probably need to use a image library like pillow to get the dimensions.)

Feel free to reach out if you need support. And let me know if you don’t have time to tackle this.

[returntoreality]

Thanks for looking at it, I can add the docs and unit test of course. I'll look into it the next days. I think the beets.util.ArtResizer utility library could be used to get the dimensions, what do you think?

[geigerzaehler]

Thanks for looking at it, I can add the docs and unit test of course. I'll look into it the next days.

Awesome!

I think the beets.util.ArtResizer utility library could be used to get the dimensions, what do you think?

I think you’re right, that should work, too.

[geigerzaehler]

The test failures have been fixed upstream and on the main branch. If you rebase, they should go away.

[geigerzaehler]

This looks great! There are some Ruff and pyright issues that need to be addressed and then I’ll merge it.

[returntoreality]

I think I have the issues now fixed

[returntoreality]

Hm, the last failure seems to be caused by this issue in beets: beetbox/beets#5414
This is probably because Windows has a convert tool, which is not from imagemagick and beets thinks imagemagick is installed. Not sure how I can fix this. One way would be to install imagemagick in the windows environment I guess.

[geigerzaehler]

Thanks for the fixes. Yeah, the test failure on windows is annoying. I think the easiest solution would be to separate the resizing test and just skip it on windows. But that shouldn’t block this PR so I’ll go ahead and merge it. Thanks again for the contribution 🙇‍♂️