Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused variables, module and apply suggestions from Ruff #569

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Removed unused variables, module and apply suggestions from Ruff #569

merged 6 commits into from
Aug 2, 2024

Conversation

AlexKurek
Copy link
Contributor

No description provided.

tukss
tukss requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@tukss tukss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup. I've reviewed the changes and suggested removing some parts entirely instead of just copying. For others I think keeping the commented variables is better.

The cleanup if the ifs is particularly appreciated. Thanks!

post_processing/rayleigh_diagnostics.py Outdated Show resolved Hide resolved
post_processing/rayleigh_diagnostics.py Outdated Show resolved Hide resolved
post_processing/rayleigh_diagnostics.py Outdated Show resolved Hide resolved
post_processing/rayleigh_diagnostics.py Outdated Show resolved Hide resolved
post_processing/rayleigh_diagnostics.py Outdated Show resolved Hide resolved
AlexKurek and others added 5 commits August 1, 2024 21:42
@AlexKurek @tukss
Update post_processing/rayleigh_diagnostics.py
146e6fb 
Co-authored-by: Philipp Edelmann <edelmann-github@fs.tum.de>
@AlexKurek @tukss
Update post_processing/rayleigh_diagnostics.py
eb588e3 
Co-authored-by: Philipp Edelmann <edelmann-github@fs.tum.de>
@AlexKurek @tukss
Update post_processing/rayleigh_diagnostics.py
9be52cb 
Co-authored-by: Philipp Edelmann <edelmann-github@fs.tum.de>
@AlexKurek @tukss
Update post_processing/rayleigh_diagnostics.py
804ee85 
Co-authored-by: Philipp Edelmann <edelmann-github@fs.tum.de>
@AlexKurek @tukss
Update post_processing/rayleigh_diagnostics.py
ec0a84a 
Co-authored-by: Philipp Edelmann <edelmann-github@fs.tum.de>
tukss
tukss approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@tukss tukss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me now.

@tukss tukss merged commit 6e4f07b into geodynamics:main Aug 2, 2024
7 checks passed
@AlexKurek
Copy link
Contributor Author

The cleanup if the ifs is particularly appreciated. Thanks!

This is easy if you use a linter, such as Ruff or Pylance. In VS Code you can even use both at the same time as plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tukss tukss tukss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexKurek @tukss