Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter / DCAT / Service #8526

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Formatter / DCAT / Service #8526

merged 2 commits into from
Dec 11, 2024

Conversation

fxprunayre
Copy link
Member

@fxprunayre fxprunayre commented Nov 29, 2024

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Funded by Service Public de Wallonie

@fxprunayre fxprunayre added this to the 4.4.7 milestone Nov 29, 2024
Fix service mapping for DCAT due to the change in namespace for SRV (#7806) which happened in between PRs.
@fxprunayre fxprunayre force-pushed the 44-dcat-service-namespace branch from 9d8976f to 744fa43 Compare November 29, 2024 10:50
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't test it, but code changes look fine.

I have added a comment to review, but it's not required to change it.

@fxprunayre fxprunayre merged commit 31c641d into main Dec 11, 2024
10 checks passed
@fxprunayre fxprunayre deleted the 44-dcat-service-namespace branch December 11, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants