Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter / DCAT / Improvements #8547

Merged
merged 10 commits into from
Dec 12, 2024
Merged

Formatter / DCAT / Improvements #8547

merged 10 commits into from
Dec 12, 2024

Conversation

fxprunayre
Copy link
Member

@fxprunayre fxprunayre commented Dec 9, 2024

  • Documentation / Add details about the differences between the 2 conversions)
  • GeoDCAT-AP / Extends DCAT-AP-HVD (to create proper dcatap:hvdCategory elements)
  • GeoDCAT-AP / Update SEMIC conversion with the latest version
  • GeoDCAT-AP / Update Shacl rule v3 for testing
  • DCAT-AP-HVD / Update HVD category vocabulary (now including sub-category)
  • DCAT / Add foaf:documentation mapping (required for service in HVD)
  • Encoding / CatalogRecord and Resource URI improvement
    • use first resource identifier for the resource if defined
    • use DOI if declared as metadata linkage or resource identifier
    • avoid having same URI used by 2 different objects in the graph (reported by Belgium HVD portal)
  • Encoding / Add mapping for online resource not in distribution section (eg. portrayal)

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@fxprunayre fxprunayre added this to the 4.4.7 milestone Dec 9, 2024
@fxprunayre fxprunayre force-pushed the 44-dcat-doc-and-semic-align branch from e800ce7 to 3864a91 Compare December 10, 2024 13:35
fxprunayre added a commit that referenced this pull request Dec 11, 2024
ISO metadata can be retrieved in DCAT and specific rules apply to High Value Dataset context.
See https://semiceu.github.io/DCAT-AP/releases/2.2.0-hvd/

This schematron test ISO19139 or ISO19115-3 records and check mandatory elements for datasets and services.

The mapping rule defined in the ISO to DCAT mapping are used (and some rules may require adaptation depending on user rules eg. no common practice to encode service documentation which is mandatory for HVD).

Relates to #8547
Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the added comments.

I haven't tested the changes, but apart from the comments above, the changes look good.

fxprunayre and others added 10 commits December 11, 2024 14:57
* Update SEMIC conversion with the latest version
* Improve documentation (and add details about the differences between the 2 conversions)
* CatalogRecord and Resource URI improvement
  * use first resource identifier for the resource if defined
  * use DOI if declared as metadata linkage or resource identifier
  * avoid having same URI used by 2 different objects in the graph (reported by Belgium HVD portal)
* Add mapping for online resource not in distribution section (eg. portrayal)
In GeoDCAT-AP, HVD keyword must be encoded using HVD category extension.
…tegory. The vocabulary is used to create skos:Concept with proper URI in case ISO keyword is encoded using gco:CharacterString only.
…ter/dcat/dcat-variables.xsl

Co-authored-by: Jose García <josegar74@gmail.com>
@fxprunayre fxprunayre force-pushed the 44-dcat-doc-and-semic-align branch from ec6c807 to 66d044f Compare December 11, 2024 14:07
@fxprunayre fxprunayre merged commit 8e31a5f into main Dec 12, 2024
12 checks passed
@fxprunayre fxprunayre deleted the 44-dcat-doc-and-semic-align branch December 12, 2024 11:59
fxprunayre added a commit that referenced this pull request Dec 12, 2024
ISO metadata can be retrieved in DCAT and specific rules apply to High Value Dataset context.
See https://semiceu.github.io/DCAT-AP/releases/2.2.0-hvd/

This schematron test ISO19139 or ISO19115-3 records and check mandatory elements for datasets and services.

The mapping rule defined in the ISO to DCAT mapping are used (and some rules may require adaptation depending on user rules eg. no common practice to encode service documentation which is mandatory for HVD).

Relates to #8547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants