Security assessment fixes (#1275)

* Remove DebugProbesKt.bin from prod apk. * Remove unused permisson. * Update proguard-rules.pro * Added read media permssion.
getlantern · Dec 31, 2024 · efa0ad1 · efa0ad1
1 parent 1fdb1e6
commit efa0ad1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/android/app/build.gradle b/android/app/build.gradle
@@ -49,6 +49,7 @@ android {
     }
     // Use legacy packaging to helps reduce apk size
     packagingOptions{
+        exclude "DebugProbesKt.bin"
         jniLibs {
             useLegacyPackaging true
         }
@@ -356,8 +357,7 @@ dependencies {
 
     implementation files('libs/opuslib-release.aar')
     implementation 'com.github.getlantern:secrets-android:f6a7a69f3d'
-//    implementation 'com.github.getlantern:db-android:6c0525eeb9'
-//    implementation 'com.github.getlantern:messaging-android:eabf104396'
+
 
     implementation 'com.github.getlantern:db-android:a137a028d4'
     implementation 'com.github.getlantern:messaging-android:4c346e64ee'

diff --git a/android/app/proguard-rules.pro b/android/app/proguard-rules.pro
@@ -219,4 +219,3 @@
 ##---------------Begin: proguard configuration for Signal  ----------
 -keep class org.whispersystems.** { *; }
 ##---------------End: proguard configuration for Signal  ----------
-#
diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
@@ -8,8 +8,11 @@
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
     <uses-permission android:name="android.permission.VIBRATE" />
-    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
-    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
+
+    <uses-permission android:name="android.permission.READ_MEDIA_IMAGES" />
+    <uses-permission android:name="android.permission.READ_MEDIA_VIDEO" />
+    <uses-permission android:name="android.permission.READ_MEDIA_AUDIO" />
+
     <!-- Re-enable for Chat!
     <uses-permission android:name="android.permission.RECORD_AUDIO" />
     <uses-permission android:name="android.permission.MODIFY_AUDIO_SETTINGS"/>