feat: add checkstyle linter locally before run too #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkovari
force-pushed
the
chore/local-checkstyle-linter
branch
2 times, most recently
from
8dbad3f to
61730b0
Compare
markkovari
requested review from
AnnaUgrai,
Hsbalazs,
ramesz6,
carlos-ponton and
a team
Signed-off-by: Márk Kővári <kovarimarkofficial@gmail.com>
markkovari
force-pushed
the
chore/local-checkstyle-linter
branch
from
61730b0 to
5d814b9
Compare
carlos-ponton
approved these changes
Jul 11, 2024
|
Maybe extend it with precommit hook to prevent it even to commit bad code. |
Signed-off-by: Márk Kővári <kovarimarkofficial@gmail.com>
Signed-off-by: Márk Kővári <kovarimarkofficial@gmail.com>
|
Not the same as watchdog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our linter - watchdog is biting in our hands. We should do that more often to make this process less inconvenient. We should not even be able to build/test or other scripts with errors/warnings.
How to reproduce locally:
follow to instructions how to install (I created a script for that)
aaaaand that should be it, you won't be able to commit invalid code.
https://www.youtube.com/watch?v=d70a8PXbrb8