Implement mipmap views on the OpenGL backend #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The code looks fine, and we can leave this to a follow up, but we need to add a downlevel flag for this, and add validation at the wgpu-core level to make sure that any bound texture is only used with one range of mipmaps, so users get proper errors, not corruption.
|
We recently talked about this restriction in the committee (https://docs.google.com/document/d/1ERkTrtClVa3JSIGUUaTT3eYR9T8TtM06XNOqrkAdI94/view) and also decided on: Validate (at draw call time) that all bound textures (not storage textures) share the same mip range. |
cwfitzgerald
requested changes
Oct 23, 2023
|
I'm not very familiar with the wgpu-core level so I'll leave that as follow up work. |
cwfitzgerald
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
mipmapexample work on AMD HD 5870 / llvmpipe on Windows.