-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): generate default template when config file is not found #3460
base: main
Are you sure you want to change the base?
Conversation
119f959
to
3beac4c
Compare
Notably, this PR automatically initializes the file on the first attempted load, rather than as a part of |
As for the contents of the template- there are some changes to my suggested template that are definitely improvements, but some of the new wording is a little sloppy, the text jumps around between moods in a strange way, extraneous commentary is included which will reduce the chance of a user properly reading it (users could not care less about the philosophical basis of the configuration file, they just want to change their font and color scheme), and not leading with the docs link front and center is definitely worse. |
I agree, I don't think we should be doing this in the load portion. |
I feel like I prefer this over only generating when Plus, when they follow the docs and try to find the config file at |
Closes #3203