Restore hidden titlebar after fullscreen #3572
Open
+58
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristeahub
force-pushed
the
cto/titlebar-hidden-after-fullscreen
branch
from
68997eb to
12c29de
Compare
This fixes ghostty-org#3535 . There exists an issue in ghostty on mac where if you have hidden your titlebar, then enter fullscreen, the titlebar will reappear after exiting fullscreen. The reason for this is that after exiting fullscreen macos reapplies some styling on the new window created after exiting fullscreen. To combat this we will reapply the styling to hide the titlebar after exiting fullscreen. Required config: ``` macos-titlebar-style = hidden macos-non-native-fullscreen = true ``` Steps to reproduce: - Open Ghostty - Enter fullscreen (non-native) - Exit fullscreen On main you will see the titlebar reappearing after exiting fullscreen, while that does not happen with this patch.
cristeahub
force-pushed
the
cto/titlebar-hidden-after-fullscreen
branch
from
12c29de to
bff9d3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3535 .
There exists an issue in ghostty on mac where if you have hidden your titlebar, then enter fullscreen, the titlebar will reappear after exiting fullscreen.
The reason for this is that after exiting fullscreen macos reapplies some styling on the new window created after exiting fullscreen. To combat this we will reapply the styling to hide the titlebar after exiting fullscreen.
Required config:
Steps to reproduce:
On main you will see the titlebar reappearing after exiting fullscreen, while that does not happen with this patch.