Unbundle asyncore and asynchat #637
Conversation
Use `pyasyncore` and `pyasynchat` from PyPI instead.
|
For the current release the patch is a little more elaborate due to the Motivation for the patch: In Fedora we prefer shared libraries/modules over bundling them. In this case |
| install_requires=[ | ||
| "pyasyncore;python_version>='3.12'", | ||
| "pyasynchat;python_version>='3.12'", | ||
| ], |
There was a problem hiding this comment.
I think it's better to remove the 3.12 dependency and always install these 2 libs. Reason: according to https://github.com/simonrob/pyasyncore, they reflect the Python 3.9 incarnation, so I think it's better to stick with that same version also for people using Python < 3.9.
The [specific version of asyncore that is provided (https://github.com/simonrob/pyasyncore/blob/master/asyncore/init.py) is the last update before the addition of deprecation/removal warnings at import time, and is essentially equivalent to the version bundled with Python 3.9 (which was the last time the module was meaningfully updated).
There was a problem hiding this comment.
I think it's better to remove the 3.12 dependency and always install these 2 libs. Reason: according to https://github.com/simonrob/pyasyncore, they reflect the Python 3.9 incarnation, so I think it's better to stick with that same version also for people using Python < 3.9.
The [specific version of asyncore that is provided (https://github.com/simonrob/pyasyncore/blob/master/asyncore/init.py) is the last update before the addition of deprecation/removal warnings at import time, and is essentially equivalent to the version bundled with Python 3.9 (which was the last time the module was meaningfully updated).
Fair enough. I can change it, though it won't have any effect on Python < 3.12 as per the Installation part of pyasyncore's README:
"The module can be installed for earlier Python versions, but it will have no effect, and the standard library version of asyncore will be used in its place."
There was a problem hiding this comment.
Oh you're right. Then I think we're fine.
Use
pyasyncoreandpyasynchatfrom PyPI instead.