Move python deps in setup.py + add install-pydeps-test|dev make targets
#651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giampaolo
changed the title
setup.py + add install-pydeps-test|dev make targets
lurch
reviewed
Oct 24, 2024
Comment on lines
+174
to
+178
| if sys.version_info[0] < 3: # noqa: UP036 | ||
| sys.exit( | ||
| 'Python 2 is no longer supported. Latest version is 1.5.10; use:\n' | ||
| 'python3 -m pip install pyftpdlib==1.5.10' | ||
| ) |
There was a problem hiding this comment.
Is the mention of python3 here a typo?
There was a problem hiding this comment.
It is, thanks. Fixed in c4ceda4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
make install-pydeps-testandmake install-pydeps-devtargets. They can be used to install dependencies meant for running tests and for local development. They can also be installed viapip install .[test]andpip install .[dev].