Update the /git-artifacts PR comment even in cascading runs
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmit SHA To update the `/git-artifacts` comment when cascading `git-artifacts-<arch>` runs are triggered, we need a way to get from the commit SHA (which is part of the `check_run.completed` webhook) to the corresponding PR comment ID. Here, we introduce a function to do that, by using GitHub API's search functionality. The commit SHA is given verbatim, which should be good enough according to the documentation at https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests#search-by-commit-sha Further, we make use of the text match metadata (https://docs.github.com/en/rest/search/search#text-match-metadata) to match the desired PR comment and to extract the PR comment ID. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
…eliably When `/git-artifacts` has to trigger a `tag-git` run first, the actual `git-artifacts-<arch>` jobs are triggered as "cascading runs". At that stage, the connection to the original PR comment ID is lost, and therefore that comment is no longer updated to link to those `git-artifacts-<arch>` runs. With this patch, GitForWindowsHelper learns to find that PR comment ID when a completed `tag-git` check run triggers the `git-artifacts-` runs and then to update that comment accordingly. This addresses git-for-windows#38 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
rimrul
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
/git-artifactsis issued with an existing correspondingtag-gitrun, the respective comment is updated immediately with links to thegit-artifacts-*runs.However, when that
tag-gitrun does not exist, the comment is updated with a link to the newly-triggeredtag-gitrun, and when that run's completion triggers the "cascading"git-artifacts-*runs, the PR comment is no longer updated.This is unfortunate because that information is rather valuable and saves time e.g. when trying to manually validate the generated installer.
So let's try a little harder to find that comment, and update it.
This fixes #38.