guess release notes: special-case cURL (even in MINGW-packages) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In git-for-windows#34, I taught the GitForWindowsHelper GitHub App to generate better release notes for cURL. However, I failed to notice that the code changes would work only for the `component-updates` issues as well as for the MSYS2-packages PRs, but not for the MINGW-packages PRs because the package name that is derived from the latter PRs has the `mingw-w64-` prefix (and must have it, for the "is this already deployed?" check). Let's make sure that that special-casing (as well for cURL as well as for OpenSSL) work even in MINGW-packages PRs. Helped-by: Matthias Aßhauer <mha1993@live.de> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
rimrul
approved these changes
Jul 20, 2024
dscho
deleted the
guess-better-curl-release-notes-even-in-MINGW-packages-PRs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #34, I taught the GitForWindowsHelper GitHub App to generate better release notes for cURL.
However, I failed to notice that the code changes would work only for the
component-updatesissues as well as for the MSYS2-packages PRs, but not for the MINGW-packages PRs because the package name that is derived from the latter PRs has themingw-w64-prefix (and must have it, for the "is this already deployed?" check).Let's make sure that that special-casing (as well for cURL as well as for OpenSSL) work even in MINGW-packages PRs.