Fix the Check Run mirroring in build-and-deploy
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically, the input name `ref` is incorrect: we expect a commit hash there, not a ref name. That's why I changed the name while transmogrifying the code to mirror a Check Run into a separate GitHub Action. But in the `build-and-deploy` workflow definition, we cannot easily rename that input because it would require an accompanying change to `gfw-helper-github-app`, something I could not justify working on while being busy with reimplementing the Azure Release Pipeline to release Git for Windows versions as `release-git.yml`. That is the reason why I forgot to adjust the spot where this input is passed from the `build-and-deploy` workflow run to the `check-run-action`. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
When transmogrifying the Check Run mirroring code into its own GitHub Action, I accidentally inserted a space into the Check Run title between `deploy` and `_<architecture>`. Let's fix this. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
fix-check-run-in-build-and-deploy
branch
3 times, most recently
from
4796c75 to
a2fbf72
Compare
|
Now that the deployments worked, I removed the |
rimrul
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During my work on the
release-gitworkflow, I introduced a bug that caused the deployments in git-for-windows/MSYS2-packages#92 (comment) to fail.This PR fixes that.