Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
deploy: be more careful when auto-upgrading from HTTP -> HTTPS
Since we play dirty tricks with `/etc/hosts` before running the Playwright tests in order to side-step Cloudflare's caches, we need to avoid using HTTPS for git-scm.com because the certificate would not be liked by Playwright. The symptom is: Error: page.goto: net::ERR_CERT_COMMON_NAME_INVALID at https://git-scm.com/ The most likely explanation is that GitHub, when trying to verify the DNS settings, realizes that the actual DNS entries by Cloudflare do _not_ point to GitHub's servers and therefore refuses to get a custom certificate from Let's Encrypt for git-scm.com. As a consequence, the certificate it provides does not cover that domain, it only covers *.github.io. Let's just leave http://git-scm.com/ alone. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
- Loading branch information