Standardise comment explaining why extensible predicates must be defined

github · May 1, 2024 · 16dcc09 · 16dcc09
1 parent 09e59cc
commit 16dcc09
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 8 deletions.
diff --git a/csharp/ql/lib/ext/empty.model.yml b/csharp/ql/lib/ext/empty.model.yml
@@ -1,4 +1,6 @@
 extensions:
+  # Make sure that the extensible model predicates have at least one definition
+  # to avoid errors about an undefined extensionals.
   - addsTo:
       pack: codeql/csharp-all
       extensible: sourceModel

diff --git a/go/ql/lib/ext/empty.model.yml b/go/ql/lib/ext/empty.model.yml
@@ -1,5 +1,6 @@
 extensions:
-  # Make sure that the extensible model predicates are at least defined as empty.
+  # Make sure that the extensible model predicates have at least one definition
+  # to avoid errors about an undefined extensionals.
   - addsTo:
       pack: codeql/go-all
       extensible: sourceModel

diff --git a/java/ql/lib/ext/empty.model.yml b/java/ql/lib/ext/empty.model.yml
@@ -1,5 +1,6 @@
 extensions:
-  # Make sure that the extensible model predicates are at least defined as empty.
+  # Make sure that the extensible model predicates have at least one definition
+  # to avoid errors about an undefined extensionals.
   - addsTo:
       pack: codeql/java-all
       extensible: sourceModel
@@ -15,4 +16,4 @@ extensions:
   - addsTo:
       pack: codeql/java-all
       extensible: neutralModel
-    data: []
+    data: []
diff --git a/java/ql/lib/ext/experimental/empty.model.yml b/java/ql/lib/ext/experimental/empty.model.yml
@@ -1,6 +1,6 @@
-# Define the extensible prediactes related to experimental queries
-# to at least be empty.
 extensions:
+  # Make sure that the extensible model predicates have at least one definition
+  # to avoid errors about an undefined extensionals.
   - addsTo:
       pack: codeql/java-all
       extensible: experimentalSourceModel

diff --git a/javascript/ql/lib/semmle/javascript/frameworks/data/internal/empty.model.yml b/javascript/ql/lib/semmle/javascript/frameworks/data/internal/empty.model.yml
@@ -1,5 +1,6 @@
 extensions:
-  # Contribute empty data sets to avoid errors about an undefined extensionals
+  # Make sure that the extensible model predicates have at least one definition
+  # to avoid errors about an undefined extensionals.
   - addsTo:
       pack: codeql/javascript-all
       extensible: sourceModel

diff --git a/python/ql/lib/semmle/python/frameworks/data/internal/empty.model.yml b/python/ql/lib/semmle/python/frameworks/data/internal/empty.model.yml
@@ -1,5 +1,6 @@
 extensions:
-  # Contribute empty data sets to avoid errors about an undefined extensionals
+  # Make sure that the extensible model predicates have at least one definition
+  # to avoid errors about an undefined extensionals.
   - addsTo:
       pack: codeql/python-all
       extensible: sourceModel

diff --git a/ruby/ql/lib/codeql/ruby/frameworks/data/internal/empty.model.yml b/ruby/ql/lib/codeql/ruby/frameworks/data/internal/empty.model.yml
@@ -1,5 +1,6 @@
 extensions:
-  # Contribute empty data sets to avoid errors about an undefined extensionals
+  # Make sure that the extensible model predicates have at least one definition
+  # to avoid errors about an undefined extensionals.
   - addsTo:
       pack: codeql/ruby-all
       extensible: sourceModel