Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce severity of java/relative-path-command #15533

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

JLLeitschuh
Copy link
Contributor

Significantly reduces the severity of java/relative-path-command from 9.8 to 5.4

https://www.first.org/cvss/calculator/4.0#CVSS:4.0/AV:L/AC:L/AT:P/PR:H/UI:P/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N

This is the result of a conversation between myself and @JarLob that can be found in the GitHub Security Ambassadors Slack channel here: https://github-partners.slack.com/archives/C01MF7QQK3P/p1706734093860739

@JarLob's opinion was that the severity should likely be even lower than a 5.4, possibly bringing it down as much as low given the attacker would have to have significant system control to exploit this.

@atorralba
Copy link
Contributor

Hey @JLLeitschuh, thanks for your contribution. I agree that this score should be lower, and while I'd use a slightly different CVSS vector, the numeric score is pretty similar — and intuitively it makes sense that this is a high or medium-severity query rather than a critical one.

possibly bringing it down as much as low given the attacker would have to have significant system control to exploit this.

It all depends on the threat model. For a program executed remotely (like a webapp) that's mostly true, but for local programs, especially those with the SUID bit set, the exploitation is much more straightforward and impactful. So I think a medium score is a good compromise.

@atorralba atorralba merged commit b6385f7 into github:main Feb 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants