C++: Don't strip specifiers in Node.getType
#15559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were calling
getUnspecifiedType
instead ofgetUnderlyingType
in a bunch of places when computing the type of a dataflow node, and sincegetUnspecifiedType
strips away specifiers such asconst
andvolatile
we could get into a situation where a node'sgetType
returnedint
while the same node'sasExpr().getType()
returnedconst int
.The fix is to use
getUnderlyingType
instead ofgetUnspecifiedType
sincegetUnderlyingType
only resolvestypedefs
without stripping specifiers.Finally, I also fixed a bug where some nodes were not correctly specified as being dataflow nodes wrapping a glvalue instruction or operand. This also fixed some inconsistency errors.
There still are some type-related bugs, but they seem a bit more difficult to fix. I'll write up an issue for the remaining ones.
Commit-by-commit review recommended.