Ruby: Add additional sql sinks for ActiveRecord connection methods #15619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joefarebrother
changed the title
joefarebrother
force-pushed
the
ruby-activerecord-connection
branch
2 times, most recently
from
25f229d to
1eea99e
Compare
joefarebrother
changed the title
sidshank
reviewed
Feb 15, 2024
ruby/ql/lib/change-notes/2024-02-15-activerecord_connection_sql_sinks
Outdated
Show resolved
Hide resolved
joefarebrother
force-pushed
the
ruby-activerecord-connection
branch
from
1eea99e to
e36b9f4
Compare
alexrford
requested changes
Feb 21, 2024
| call = activeRecordConnectionInstance().getAMethodCall("execute") and | ||
| call = | ||
| activeRecordConnectionInstance() | ||
| .getAMethodCall([ |
There was a problem hiding this comment.
We can add create (an alias for insert) to this.
I think we can also remove select_update? I can't find this as a query execution method.
hmac
approved these changes
Feb 22, 2024
|
Ah it looks like you need an explicit re-approval from @alexrford to merge this - I thought my approval would be enough. Sorry! |
alexrford
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/codeql-team/issues/2616 and https://github.com/github/codeql-team/issues/2559