Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External flow: standardize empty.model.yml #16392

Merged
merged 3 commits into from
May 2, 2024
+15 −8
Merged

External flow: standardize empty.model.yml #16392

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09e59cc
Name files with empty definitions of MaD extensible predicates to ero…
owen-mc May 1, 2024
16dcc09
Standardise comment explaining why extensible predicates must be defined
owen-mc May 1, 2024
83249cd
Fix grammar in comment
owen-mc May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions csharp/ql/lib/ext/default.model.yml → csharp/ql/lib/ext/empty.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
extensions:
# Make sure that the extensible model predicates have at least one definition
# to avoid errors about an undefined extensionals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 'an'?

- addsTo:
pack: codeql/csharp-all
extensible: sourceModel
Expand Down
3 changes: 2 additions & 1 deletion go/ql/lib/ext/dummy.model.yml → go/ql/lib/ext/empty.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
extensions:
# Make sure that the extensible model predicates are at least defined as empty.
# Make sure that the extensible model predicates have at least one definition
# to avoid errors about an undefined extensionals.
- addsTo:
pack: codeql/go-all
extensible: sourceModel
Expand Down
5 changes: 3 additions & 2 deletions java/ql/lib/ext/dummy.model.yml → java/ql/lib/ext/empty.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
extensions:
# Make sure that the extensible model predicates are at least defined as empty.
# Make sure that the extensible model predicates have at least one definition
# to avoid errors about an undefined extensionals.
- addsTo:
pack: codeql/java-all
extensible: sourceModel
Expand All @@ -15,4 +16,4 @@ extensions:
- addsTo:
pack: codeql/java-all
extensible: neutralModel
data: []
data: []
4 changes: 2 additions & 2 deletions java/ql/lib/ext/experimental/dummy.model.yml → java/ql/lib/ext/experimental/empty.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Define the extensible prediactes related to experimental queries
# to at least be empty.
extensions:
# Make sure that the extensible model predicates have at least one definition
# to avoid errors about an undefined extensionals.
- addsTo:
pack: codeql/java-all
extensible: experimentalSourceModel
Expand Down
3 changes: 2 additions & 1 deletion ...script/frameworks/data/internal/model.yml → .../frameworks/data/internal/empty.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
extensions:
# Contribute empty data sets to avoid errors about an undefined extensionals
# Make sure that the extensible model predicates have at least one definition
# to avoid errors about an undefined extensionals.
- addsTo:
pack: codeql/javascript-all
extensible: sourceModel
Expand Down
3 changes: 2 additions & 1 deletion python/ql/lib/semmle/python/frameworks/data/internal/empty.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
extensions:
# Contribute empty data sets to avoid errors about an undefined extensionals
# Make sure that the extensible model predicates have at least one definition
# to avoid errors about an undefined extensionals.
- addsTo:
pack: codeql/python-all
extensible: sourceModel
Expand Down
3 changes: 2 additions & 1 deletion ...l/ruby/frameworks/data/internal/model.yml → .../frameworks/data/internal/empty.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
extensions:
# Contribute empty data sets to avoid errors about an undefined extensionals
# Make sure that the extensible model predicates have at least one definition
# to avoid errors about an undefined extensionals.
- addsTo:
pack: codeql/ruby-all
extensible: sourceModel
Expand Down
Loading