Data flow: Rework reverse flow through parameters #18109
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
dataflow/reverse-flow
branch
from
8d261e5 to
2e254e4
Compare
hvitved
force-pushed
the
dataflow/reverse-flow
branch
4 times, most recently
from
8f34281 to
f37447b
Compare
hvitved
force-pushed
the
dataflow/reverse-flow
branch
8 times, most recently
from
a2dc9b1 to
13b8249
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
dataflow/reverse-flow
branch
7 times, most recently
from
3b814f0 to
d0673a1
Compare
hvitved
force-pushed
the
dataflow/reverse-flow
branch
3 times, most recently
from
6534946 to
296d8fb
Compare
hvitved
force-pushed
the
dataflow/reverse-flow
branch
from
296d8fb to
45c5da2
Compare
| ) | ||
| or | ||
| // flow through: no prior read | ||
| exists(ArgNode arg | |
Check warning
Code scanning / CodeQL
Candidate predicate not marked as `nomagic` Warning
| ) { | ||
| exists(ParameterPosition pos | | ||
| parameterValueFlowsToPreUpdate(p, n) and | ||
| p.isParameterOf(_, pos) and |
Check warning
Code scanning / CodeQL
Candidate predicate not marked as `nomagic` Warning
| ) { | ||
| c = getNodeEnclosingCallable(n) and | ||
| paramReturnNode(n, p, _, kind) | ||
| } |
Check warning
Code scanning / CodeQL
Candidate predicate not marked as `nomagic` Warning
hvitved
force-pushed
the
dataflow/reverse-flow
branch
from
45c5da2 to
23d552e
Compare
hvitved
force-pushed
the
dataflow/reverse-flow
branch
from
23d552e to
d84ca39
Compare
| @@ -2267,14 +2299,15 @@ | |||
| ) | |||
| or | |||
| // flow out of a callable | |||
| exists(ReturnPosition pos | | |||
| revFlowOut(_, node, pos, state, _, _, _, ap) and | |||
| exists(DataFlowCall call, ReturnPosition pos | | |||
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.