JS: Merge 'main' into shared dataflow branch #18326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect this is due to some fixes in the DeduplicatePathGraph module
asgerf
force-pushed
the
js/shared-dataflow-bump
branch
from
3064e6d to
942ba18
Compare
There was a problem hiding this comment.
Copilot reviewed 32 out of 51 changed files in this pull request and generated no comments.
Files not reviewed (19)
- javascript/ql/lib/semmle/javascript/internal/flow_summaries/Maps.qll: Language not supported
- javascript/ql/lib/utils/test/InlineFlowTest.qll: Language not supported
- javascript/ql/test/library-tests/Arrays/DataFlow.expected: Language not supported
- javascript/ql/test/library-tests/Arrays/DataFlow.ql: Language not supported
- javascript/ql/test/library-tests/Arrays/TaintFlow.expected: Language not supported
- javascript/ql/test/library-tests/Arrays/TaintFlow.ql: Language not supported
- javascript/ql/test/library-tests/Barriers/SimpleBarrierGuard.ql: Language not supported
- javascript/ql/test/library-tests/Classes/tests.ql: Language not supported
- javascript/ql/test/library-tests/FlowSummary/test.ql: Language not supported
- javascript/ql/test/library-tests/Generators/DataFlow.ql: Language not supported
- javascript/ql/test/library-tests/LabelledBarrierGuards/LabelledBarrierGuards.ql: Language not supported
- javascript/ql/test/library-tests/Promises/flow.qll: Language not supported
- javascript/ql/test/library-tests/Routing/test.ql: Language not supported
- javascript/ql/test/library-tests/Security/heuristics/HeuristicSource.ql: Language not supported
- javascript/ql/test/library-tests/TaintBarriers/tests.ql: Language not supported
- javascript/ql/test/library-tests/TaintTracking/BasicTaintTracking.expected: Language not supported
- javascript/ql/test/library-tests/TaintTracking/BasicTaintTracking.ql: Language not supported
- javascript/ql/test/library-tests/TaintTracking/DataFlowTracking.expected: Language not supported
- javascript/ql/test/library-tests/TaintTracking/DataFlowTracking.ql: Language not supported
Comments suppressed due to low confidence (2)
javascript/ql/test/library-tests/TaintTracking/tst.js:79
- Ensure that the function 'unknown()' is defined and used correctly. If 'unknown()' is not defined, this will cause a runtime error.
sink(grouped.get(unknown())); // NOT OK
javascript/ql/test/library-tests/TaintTracking/tst.js:84
- Ensure that the function 'unknown()' is defined and used correctly. If 'unknown()' is not defined, this will cause a runtime error.
sink(grouped.get(unknown())); // NOT OK
Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more
|
As usual the failing QLDoc Checks can be ignored on this PR, because the target branch ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.