Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Handle sizeof... for types and template template parameters #18353

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Dec 20, 2024

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Dec 20, 2024
@Copilot Copilot bot review requested due to automatic review settings December 20, 2024 16:10
@jketema jketema requested a review from a team as a code owner December 20, 2024 16:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated 1 comment.

Files not reviewed (6)
  • cpp/downgrades/c3881af7e5b247d126aea68a1901b4497adf3d83/upgrade.properties: Language not supported
  • cpp/ql/lib/semmle/code/cpp/PrintAST.qll: Language not supported
  • cpp/ql/lib/semmle/code/cpp/exprs/Cast.qll: Language not supported
  • cpp/ql/lib/semmlecode.cpp.dbscheme: Language not supported
  • cpp/ql/lib/upgrades/d6a03a00b9824f27241b58b8e18208f31c03904a/upgrade.properties: Language not supported
  • cpp/ql/test/library-tests/cpp11_g/cfg.expected: Language not supported

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

cpp/ql/lib/change-notes/2024-12-20-sizeof-pack.md Outdated Show resolved Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jketema jketema merged commit b60c860 into github:main Dec 20, 2024
13 of 16 checks passed
@jketema jketema deleted the template-parameters-2 branch December 20, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants