-
Notifications
You must be signed in to change notification settings - Fork 60.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to declare support for uv compiled requirements.txt #34569
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@beagold Thanks so much for opening a PR! I'll get this triaged for review ✨ |
@github/docs-content Please ensure @jonjanego has reviewed / approved this PR before this is merged - thank you! 💛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @beagold — this looks good from a Docs perspective. I've left some small things for you and @jonjanego to take a look at.
Even though I'm approving this, it won't be merged just yet, but I see no major blockers so I'm leaving the approval to make the process smoother when we're ready to merge 👍
@beagold Howdy! 👋 Would you be able to take a peek at the suggestions / comments above? 💛 |
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com>
I am so sorry! Thanks for the ping, it seems like GitHub didnt send me the push notification otherwise |
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproving :)
Why:
Accompanies dependabot/dependabot-core#10040
What's being changed (if available, include any code snippets, screenshots, or gifs):
Aim is to declare in the documentation that
uv
is partially supported when updating compiledrequirements.txt
files.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.