-
Notifications
You must be signed in to change notification settings - Fork 60.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the fact that Rouge only recognises lower-case language identifiers #35697
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@nisbet-hubbard Thanks so much for opening a PR! I'll get this triaged for review ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this pull request. You learn something new every day. I hadn't realized that you could use anything other than lower-case 😄
I've suggested some changes to the wording and added a link to the supported language list for Rouge. I'd normally leave my comments open for a few days to give you an opportunity to come back to me with your thoughts on the suggestions. However, I'm going to be out of the office over the holiday period, so I'll apply my changes and merge this so the information is published without a long delay.
content/pages/setting-up-a-github-pages-site-with-jekyll/about-github-pages-and-jekyll.md
Outdated
Show resolved
Hide resolved
.../writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks.md
Outdated
Show resolved
Hide resolved
.../writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks.md
Outdated
Show resolved
Hide resolved
…rmatting/creating-and-highlighting-code-blocks.md
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
GitHub accepts both ```Diff and ```diff for the purposes of syntax highlighting, but GitHub Pages will only highlight a ```diff code block.
What's being changed (if available, include any code snippets, screenshots, or gifs):
Documented this caveat.
Check off the following: