Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: missing period #35741

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shobhit-Nagpal
Copy link

Why:

To close an issue regarding docs

Closes: #35738

What's being changed (if available, include any code snippets, screenshots, or gifs):

  • Added a missing period in data/reusables/actions/about-oidc-short-overview.md

image

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing.

Copy link

welcome bot commented Dec 21, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 21, 2024
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/about-github-actions/about-continuous-deployment-with-github-actions.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/security-for-github-actions/security-guides/security-hardening-for-github-actions.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/security-for-github-actions/security-guides/using-secrets-in-github-actions.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/use-cases-and-examples/deploying/deploying-docker-to-azure-app-service.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/use-cases-and-examples/deploying/deploying-java-to-azure-app-service.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/use-cases-and-examples/deploying/deploying-net-to-azure-app-service.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/use-cases-and-examples/deploying/deploying-nodejs-to-azure-app-service.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/use-cases-and-examples/deploying/deploying-php-to-azure-app-service.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/use-cases-and-examples/deploying/deploying-python-to-azure-app-service.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/use-cases-and-examples/deploying/deploying-to-amazon-elastic-container-service.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/use-cases-and-examples/deploying/deploying-to-azure-kubernetes-service.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/use-cases-and-examples/deploying/deploying-to-azure-static-web-app.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/use-cases-and-examples/deploying/deploying-to-google-kubernetes-engine.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team ready to merge This pull request is ready to merge and removed triage Do not begin working on this issue until triaged by the team labels Dec 23, 2024
@nguyenalex836
Copy link
Contributor

@Shobhit-Nagpal Thank you so much for opening a PR with this fix! Your changes look great ✨ We are currently in a repo freeze, but we'll get this merged as soon as the freeze ends on Jan 6th 💛

@Shobhit-Nagpal
Copy link
Author

@Shobhit-Nagpal Thank you so much for opening a PR with this fix! Your changes look great ✨ We are currently in a repo freeze, but we'll get this merged as soon as the freeze ends on Jan 6th 💛

Thank you raising this issue in the first place, learnt quite a bit about how open-source docs are written while going through the repo.

Thank you so much :))

@Pricer187

This comment was marked as spam.

@Pricer187

This comment was marked as spam.

@nguyenalex836
Copy link
Contributor

@Shobhit-Nagpal We're so glad to hear that 💛 Thank you for your willingness to contribute and make our docs better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
3 participants