refactor(graphql): improve queries by returning a simple cursor #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `membersWithRole` connection has a `pageInfo` containing the `endCursor`. It is equivalent to look at the last edge's cursor but creates a smaller return object. This update the queries, code and fixtures to reflect the new way to paginate.
|
Should we expose |
|
That's a good question, given that I'm going to fix the acceptance tests as well, I'd say let's keep this PR as small as possible and see if it's needed. The current pagination logic works without |
This corresponds to the change in the previous commit and will bridge the gap between the test and new data format.
jasonmacgowan
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
membersWithRoleconnection has apageInfocontaining theendCursor. It is equivalent to look at the last edge's cursor but creates a smaller return object.This update the queries, code and fixtures to reflect the new way to paginate.
Before:
After:
Proof the cursor is the same using https://docs.github.com/en/graphql/overview/explorer:
