Implement ASCII art only flag #45
Merged
+51
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisreddington
approved these changes
Dec 28, 2024
|
Thanks @ephyran! ✨ I think this approach solves the immediate request of an ASCII only approach. Longer term, with the amount of requests that have come in around customisability, I'm thinking that some form of config file might be useful where a user can specify their preferred usage of Skyline (e.g. Generating STL or not, including years or not, etc.) But this approach looks good for the immediate request - Thank you! 😄 🎉 And thanks to @mattr- for the original issue too! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address #36.
It includes the addition of a --art-only flag that suppresses both the header and footer of the ASCII preview, as well as prevents the generation of an STL file.