Fix empty contribution showing high-level blocks #54
+69
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharthkoli
requested review from
chrisreddington and
leereilly
as code owners
|
Thanks for the contribution @siddharthkoli! I've added in a test to verify the empty blocks scenario as well 😄 This will make its way into the next release. Thank you for your support here! ✨ |
chrisreddington
approved these changes
Dec 28, 2024
chrisreddington
approved these changes
Dec 28, 2024
|
Thanks a lot @chrisreddington! This was my first open source contribution. Looking forward to making more contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where for a user having an empty contribution graph for a year, the ASCII art would have a grid filled with all medium blocks.
Fixed issue with the normalization which had an unchecked divide by 0.
Fixes #50
Before:
After:
